Added realistic movement trail #5702
Conversation
| @@ -0,0 +1,32 @@ | |||
| shader_type spatial; | |||
|
|
|||
| uniform sampler2D bubble_noise; | |||
There was a problem hiding this comment.
camelCase naming should be used in Thrive shaders.
| process_priority = 2 | ||
| cast_shadow = 0 |
There was a problem hiding this comment.
You have changed script order priority and shadow settings for the membrane. If these are intentional, could you explain why these are necessary?
| layers = 2 | ||
| material_override = SubResource("ShaderMaterial_2") | ||
| cast_shadow = 0 | ||
| mesh = SubResource("BoxMesh_1") |
There was a problem hiding this comment.
What is the reason behind changing the engulf mesh and the mucocyst mesh (I won't comment on that separately)?
There was a problem hiding this comment.
On reviewing the code here, I no longer think that this is in any way necessary to write in C++. We already do very similar geometry updating in C# so I don't think this deserves any such special consideration. Especially as you are using the mesh surface tool which has the same exact API from C# as it does from C++ (so this doesn't even take advantage of any special optimizations that only C++ could do). I think it would be probably a better idea to implement the ripple effect as a single C# ECS system that uses a single multimesh to draw all of the effects (or direct geometry buffers that are updated), because I think it should be possible to use a multimesh instance with a sphere model to draw all of the cell's trails with a single draw call. Writing that in C# should be even overall faster than this not super polished approach (I have many more small tweak comments but I'll refrain from making them until the big architecture picture is worked out, like for example how the particle emitter is manually positioned even though it is already scene attached so that should be totally unnecessary).
Brief Description of What This PR Does
This PR adds a visual enhancement for microbe movements, the core class of this implementation is the c++ "Ripple" class that generates smooth, fading trails behind all moving microbes, then the scene emits bubble particles around the trail, all particles are generated by a shader with the same name as the new class. Under the hood the implementation uses triangle strips for the mesh generation it automatically cleans old trail points based on age and distance.
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.